Ticket #1190: 1190-nospawn.darcs.patch

Tue Oct 26 23:13:42 PDT 2010  "Brian Warner <warner@lothar.com>"
  * 'tahoe start': use import+call rather than find+spawn
  
  This removes the need to use a locally-built (dependency) bin/twistd, and
  removes a big chunk of behavior differences between unix and windows. It
  also happens to resolve the "client node probably started" uncertainty.
  Might help with #1190, #602, and #71.

New patches:

['tahoe start': use import+call rather than find+spawn
"Brian Warner <warner@lothar.com>"**20101027061342
 
 This removes the need to use a locally-built (dependency) bin/twistd, and
 removes a big chunk of behavior differences between unix and windows. It
 also happens to resolve the "client node probably started" uncertainty.
 Might help with #1190, #602, and #71.
] {
hunk ./src/allmydata/scripts/startstop_node.py 51
     else:
         nodetype = "unknown (%s)" % tac
 
-    cmd = find_exe.find_exe('twistd')
-    if not cmd:
-        # If 'twistd' wasn't on $PATH, maybe we're running from source and
-        # Twisted was built as one of our dependencies. If so, we're at
-        # BASEDIR/src/allmydata/scripts/startstop_node.py, and it's at
-        # BASEDIR/support/$BINDIR/twistd
-        up = os.path.dirname
-        TAHOEDIR = up(up(up(up(os.path.abspath(__file__)))))
-        if sys.platform == "win32":
-            bin_dir = "Scripts"
-        else:
-            bin_dir = "bin"
-        bindir = os.path.join(TAHOEDIR, "support", bin_dir)
-
-        maybe = os.path.join(bindir, "twistd")
-        if os.path.exists(maybe):
-            cmd = [maybe]
-            oldpath = os.environ.get("PATH", "").split(os.pathsep)
-            os.environ["PATH"] = os.pathsep.join(oldpath + [bindir])
-            # sys.path and $PYTHONPATH are taken care of by the extra code in
-            # 'setup.py trial'
-        else:
-            maybe = maybe+'.py'
-            if os.path.exists(maybe):
-                cmd = [sys.executable, maybe]
-                oldpath = os.environ.get("PATH", "").split(os.pathsep)
-                os.environ["PATH"] = os.pathsep.join(oldpath + [bindir])
-                # sys.path and $PYTHONPATH are taken care of by the extra code in
-                # 'setup.py trial'
-
-    if not cmd:
-        print "Can't find twistd (it comes with Twisted).  Aborting."
-        sys.exit(1)
-
-    cmd.extend(["-y", tac])
+    args = ["twistd", "-y", tac]
     if opts["syslog"]:
hunk ./src/allmydata/scripts/startstop_node.py 53
-        cmd.append("--syslog")
+        args.append("--syslog")
     elif nodetype in ("client", "introducer"):
         fileutil.make_dirs(os.path.join(basedir, "logs"))
hunk ./src/allmydata/scripts/startstop_node.py 56
-        cmd.extend(["--logfile", os.path.join("logs", "twistd.log")])
+        args.extend(["--logfile", os.path.join("logs", "twistd.log")])
     if opts["profile"]:
hunk ./src/allmydata/scripts/startstop_node.py 58
-        cmd.extend(["--profile=profiling_results.prof", "--savestats",])
-    curdir = os.getcwd()
-    try:
-        os.chdir(basedir)
-        rc = os.system(' '.join(cmd))
-    finally:
-        os.chdir(curdir)
-    if rc == 0:
-        print >>out, "%s node probably started" % nodetype
-        return 0
-    else:
-        print >>err, "%s node probably not started" % nodetype
-        return 1
+        args.extend(["--profile=profiling_results.prof", "--savestats",])
+    # now we're committed
+    os.chdir(basedir)
+    from twisted.scripts import twistd
+    sys.argv = args
+    twistd.run()
+    # run() doesn't return: the parent does os._exit(0) in daemonize(), so
+    # we'll never get here. If application setup fails (e.g. ImportError),
+    # run() will raise an exception.
 
 def do_stop(basedir, out=sys.stdout, err=sys.stderr):
     print >>out, "STOPPING", quote_output(basedir)
}

Context:

[docs/known_issues.rst: Add section on traffic analysis. Fix URL for current version of file.
david-sarah@jacaranda.org**20101024234259
 Ignore-this: f3416e79d3bb833f5118da23e85723ad
] 
[test_mutable.py: add test for ResponseCache memory leak. refs #1045, #1129
david-sarah@jacaranda.org**20101024193409
 Ignore-this: 3aee7f0677956cc6deaccb4d5b8e415f
] 
[test_encodingutil.py: test_argv_to_unicode modified the wrong encoding variable. fixes #1214
david-sarah@jacaranda.org**20101023035810
 Ignore-this: e5f1f849931b96939facc53d93ff61c5
] 
[docs/running.html: fix missing end-quote, and change frontends/ doc references to .rst.
david-sarah@jacaranda.org**20101024171500
 Ignore-this: 47c645a6595e1790b1d1adfa71af0e1d
] 
[docs/running.html: 'tahoe create-client' now creates a node with storage disabled. Also change configuration.txt references to configuration.rst.
david-sarah@jacaranda.org**20101024170431
 Ignore-this: e5b048055494ba3505bb8a506610681c
] 
[doc: add explanation of the motivation for the surprising and awkward API to erasure coding
zooko@zooko.com**20101015060202
 Ignore-this: 428913ff6e1bf5b393deffb1f20b949b
] 
[setup: catch and log ValueError from locale.getdefaultlocale() in show-tool-versions.py
zooko@zooko.com**20101015054440
 Ignore-this: 827d91490562c32ed7cf6526dfded773
 I got a bug report from Mathias Baert showing that locale.getdefaultlocale() raises an exception on his Mac OS X system. Heh.
] 
[docs: update how-to-make-a-release doc with a few tweaks from the 1.8.0 process
zooko@zooko.com**20101015054413
 Ignore-this: ca5e9478531a3393792ae283239549dd
] 
[docs: update NEWS ref: #1216
zooko@zooko.com**20101015053719
 Ignore-this: 2e0b92e4145d667cdf075e64b7965530
] 
[docs: fix tab-vs-spaces, make some CLI examples <tt>/"literal", wrap some to
Brian Warner <warner@lothar.com>**20101015060606
 Ignore-this: eae08bdf0afb19a2fbf41c31e70a8122
 80-cols, remove spurious whitespace. Add rst2html.py rule to Makefile.
] 
[docs: add Peter Secor, Shawn Willden, and Terrell Russell as signatories to docs/backdoors.rst
zooko@zooko.com**20101015053242
 Ignore-this: c77adf819d664f673e17c4aaeb353f33
] 
[docs: convert all .txt docs to .rst thanks to Ravi Pinjala
zooko@zooko.com**20101015052913
 Ignore-this: 178a5122423189ecfc45b142314a78ec
 fixes #1225
] 
[docs: add statement on our refusal to insert backdoors
zooko@zooko.com**20101006051147
 Ignore-this: 644d308319a7b80c4434bdff9760404a
] 
[setup: add --multi-version to the "setup.py develop" command-line
zooko@zooko.com**20101005182350
 Ignore-this: 709155cc21caff29826b8d41a8c8d63d
 fixes #530. I earlier tried this twice (see #530 for history) and then twice rolled it back due to some problems that arose. However, I didn't write down what the problems were in enough detail on the ticket that I can tell today whether those problems are still issues, so here goes the third attempt. (I did write down on the ticket that it would not create site.py or .pth files in the target directory with --multi-version mode, but I didn't explain why *that* was a problem.)
] 
[setup: use execfile to access _auto_deps.py in its proper location of src/allmydata/ instead of copying it into place when setup.py is executed
zooko@zooko.com**20100906055714
 Ignore-this: c179b42672d775580afad40121f86812
] 
[trivial: M-x whitespace-cleanup
zooko@zooko.com**20100903144712
 Ignore-this: 1bb764d11ac69b4a35ea091cfb13158a
] 
[minor: remove unused interface declaration, change allmydata.org to tahoe-lafs.org in email address, fix wording in relnotes.txt
zooko@zooko.com**20100930153708
 Ignore-this: a452969228afed2774de375e29fa3048
] 
[immutable/repairer.py: don't use the default happiness setting when repairing
Kevan Carstensen <kevan@isnotajoke.com>**20100927200102
 Ignore-this: bd704d9744b970849da8d46a16b8089a
] 
[NEWS: note dependency updates to pycryptopp and pycrypto.
david-sarah@jacaranda.org**20100924191207
 Ignore-this: eeaf5c9c9104f24c450c2ec4482ac1ee
] 
[TAG allmydata-tahoe-1.8.0
zooko@zooko.com**20100924021631
 Ignore-this: 494ca0a885c5e20c883845fc53e7ab5d
] 
Patch bundle hash:
a51cc7ad4c2b8030d353bd9dbc4be1f9287e0814