| 2 | | daira: dawuud: there is a shallow reason why test_magicfolder_start_service doesn't work on the current 2489.write_downloaded_file.1 branch, and a deeper reason |
| 3 | | daira: the shallow reason is that self.basedir needs to be created before self.local_dir |
| 4 | | daira: the deeper reason is that create_invite_join_magic_folder depends on the client already existing |
| 5 | | daira: so we cannot call it in the client_config_hook, because that's called in order to create the client |
| 6 | | daira: and self.g.clients[0] is not set until it has returned (in fact, self.g is not set until all the config hooks have returned) |
| 7 | | daira: so we do need to set up the grid first, then call create_invite_join_magic_folder, then restart the client |
| 8 | | daira: I think the cleanest way to handle this is to add a restart_client(self, i=0) method to NoNetworkGrid |
| | 2 | daira: dawuud: there is a shallow reason why test_magicfolder_start_service |
| | 3 | doesn't work on the current 2489.write_downloaded_file.1 branch, and a |
| | 4 | deeper reason |
| | 5 | daira: the shallow reason is that self.basedir needs to be created before |
| | 6 | self.local_dir |
| | 7 | daira: the deeper reason is that create_invite_join_magic_folder depends |
| | 8 | on the client already existing |
| | 9 | daira: so we cannot call it in the client_config_hook, because that's |
| | 10 | called in order to create the client |
| | 11 | daira: and self.g.clients[0] is not set until it has returned (in fact, |
| | 12 | self.g is not set until all the config hooks have returned) |
| | 13 | daira: so we do need to set up the grid first, then call |
| | 14 | create_invite_join_magic_folder, then restart the client |
| | 15 | daira: I think the cleanest way to handle this is to add a |
| | 16 | restart_client(self, i=0) method to NoNetworkGrid |
| 10 | | daira: incidentally, NoNetworkGrid is a misnomer because the client does listen on loopback to its web port. it's only the connections between clients and servers that are no-network |
| 11 | | daira: (if the client didn't listen on its web port then create_invite_join_magic_folder wouldn't work) |
| | 18 | daira: incidentally, NoNetworkGrid is a misnomer because the client does |
| | 19 | listen on loopback to its web port. it's only the connections between |
| | 20 | clients and servers that are no-network |
| | 21 | daira: (if the client didn't listen on its web port then |
| | 22 | create_invite_join_magic_folder wouldn't work) |
