Changes between Version 4 and Version 5 of Ticket #2891


Ignore:
Timestamp:
2017-08-10T20:02:55Z (7 years ago)
Author:
warner
Comment:

added intermittence from an old build of PR421 (stats.py, web/status.py)

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2891 – Description

    v4 v5  
    2525 * [https://github.com/tahoe-lafs/tahoe-lafs/blob/95ac5494ffaad61494e0616286894a20b87b7da8/src/allmydata/util/dictutil.py#L597 L 597 ValueOrderedDict.pop]
    2626
     27* src/allmydata/stats.py
     28 * [https://github.com/tahoe-lafs/tahoe-lafs/blob/3f2f7dfb05ad7f505b70323459aec8d70d2a3ab5/src/allmydata/stats.py#L68 L64-68 LoadMonitor.get_stats()]
     29  * noticed in a [https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/421/changes build of PR421]
     30  * get_stats() returns an average of the last 60 datapoints, but if there are no datapoints at all, a different branch is taken
     31  * that no-datapoints branch is sometimes not covered by the tests
     32
     33* src/allmydata/web/status.py
     34 * also from that PR421 build
     35 * [https://github.com/tahoe-lafs/tahoe-lafs/blob/3f2f7dfb05ad7f505b70323459aec8d70d2a3ab5/src/allmydata/web/status.py#L758 L758 RetrieveStatusPage.render_server_timings()]
     36  * sometimes the `fetch_per_server` timing data is empty, which skips parts of this function
     37 * [https://github.com/tahoe-lafs/tahoe-lafs/blob/3f2f7dfb05ad7f505b70323459aec8d70d2a3ab5/src/allmydata/web/status.py#L925 L925 MapupdateStatusPage.render_privkey_from()]
     38  * sometimes this is called when the privkey has not been fetched, so it skips the affirmative side of the branch
     39