test_ftp_auth_keyfile reported to fail on Windows

[daira]

Reported by WinLAFS on tahoe-dev (against master):

[ERROR]
Traceback (most recent call last):
  File "c:\lafs\src\allmydata\test\test_client.py", line 220, in test_ftp_auth_keyfile
    c = client.Client(basedir) # just make sure it can be instantiated
  File "c:\lafs\src\allmydata\client.py", line 151, in __init__
    self.init_ftp_server()
  File "c:\lafs\src\allmydata\client.py", line 470, in init_ftp_server
    s = ftpd.FTPServer(self, accountfile, accounturl, ftp_portstr)
  File "c:\lafs\src\allmydata\frontends\ftpd.py", line 318, in __init__
    c = AccountFileChecker(self, accountfile)
  File "c:\lafs\src\allmydata\frontends\auth.py", line 34, in __init__
    for line in open(abspath_expanduser_unicode(accountfile), "r"):
exceptions.IOError: [Errno 2] No such file or directory: u'\\\\?\\C:\\lafs\\_trial_temp\\private\\accounts'

allmydata.test.test_client.Basic.test_ftp_auth_keyfile

[daira]

Release-blocker because this is a new test for this release, and it should pass on all platforms.

[daira]

I can reproduce this. Looking at it now.

[daira]

For some reason the test is looking for _trial_temp\private\accounts, which does not exist, rather than _trial_temp\client.Basic.test_ftp_auth_keyfile\private\accounts which does. Will investigate further at Nuts & Bolts tomorrow.

[daira]

Oh, probably it's because a relative path private\accounts is being expanded relative to the working directory _trial_temp, rather than the node directory of the test. But why is that failing only on Windows?

[daira]

Fixed in [eb34e0d].

[daira]

The problem was that Windows used a different code path to expand the path, and that code path hadn't been updated to take account of the base parameter to fileutil.abspath_expanduser_unicode.