Magic Folder: add create commandline tool

[dawuud]

Implement a basic magic folder DMD creation command:

  tahoe magic-folder create MAGIC:

This command will depend on the invite and join commands for the other usage:

  tahoe magic-folder create MAGIC: [MY_NICKNAME LOCAL_DIR]

[dawuud]

here i've written to the boiler plate code for the magic-folder CLI subcommand system...

this commit also has naive/basic command usage for the magic-folder create command:

​https://github.com/david415/tahoe-lafs/tree/2454.magic-folder-create-tool.1 ​https://github.com/david415/tahoe-lafs/commit/cb33d9a1486ffc6250708feca6ed0c6cfad1bf81

[dawuud]

i'm having trouble getting my unit test for the create command to pass. here's my work in progress commit... it's test fails. the test name is called:

allmydata.test.test_cli_magic_folder

​https://github.com/david415/tahoe-lafs/commit/626f3447a61be466e126bd04dbc39a4696fe0da9

[dawuud]

​https://github.com/david415/tahoe-lafs/tree/2454.magic-folder-create-tool.2

but why still fail!?

` [user@tahoe-dev1 tahoe-lafs]$ ./bin/tahoe debug trial allmydata.test.test_cli_magic_folder allmydata.test.test_cli_magic_folder

CreateMagicFolder?

test_create ... [ERROR]

=============================================================================== [ERROR] Traceback (most recent call last):

File "/usr/lib64/python2.7/site-packages/twisted/python/threadpool.py", line 196, in _worker

result = context.call(ctx, function, *args, kwargs)

File "/usr/lib64/python2.7/site-packages/twisted/python/context.py", line 118, in callWithContext

return self.currentContext().callWithContext(ctx, func, *args, kw)

File "/usr/lib64/python2.7/site-packages/twisted/python/context.py", line 81, in callWithContext

return func(*args,kw)

File "/home/user/tahoe-lafs/src/allmydata/scripts/runner.py", line 148, in runner

rc = magic_folder_cli.dispatch[command](so)

File "/home/user/tahoe-lafs/src/allmydata/scripts/magic_folder_cli.py", line 66, in do_magic_folder

return f(so)

File "/home/user/tahoe-lafs/src/allmydata/scripts/magic_folder_cli.py", line 20, in create

rc = tahoe_add_alias.create_alias(options)

File "/home/user/tahoe-lafs/src/allmydata/scripts/tahoe_add_alias.py", line 57, in create_alias

nodedir = optionsnode-directory?

exceptions.KeyError?: 'node-directory'

allmydata.test.test_cli_magic_folder.CreateMagicFolder?.test_create

---

Ran 1 tests in 0.368s

FAILED (errors=1) [user@tahoe-dev1 tahoe-lafs]$

`

[dawuud]

Question to Tahoe-LAFS developers: why does CreateAliasOptions? inherit from FilesystemOptions??

Shouldn't it inherit from BasedirOptions? instead?

What does it even mean to use the create alias CLI when only a node-url is specified but a node-directory is not? How will it persist the alias to the aliases file?

[dawuud]

yay nevermind i got it working!

​https://github.com/david415/tahoe-lafs/commit/a9fbbfa14ebcda69157ca5e42f05071ff82d9f34 ​https://github.com/david415/tahoe-lafs/tree/2454.magic-folder-create-tool.2

[dawuud]

currently this basic magic-folder create command only creates an alias... the other usage will have to wait until i finish the join and invite commands.

[dawuud]

completed the join and invite functionality of the create command: ​https://github.com/david415/tahoe-lafs/commit/6cde4dc88840bd76d9c0999a9df0ed91f980b04a

unit tests coming soon...

[dawuud]

completed unit tests... tied them all together with the join unit tests which look at the magic folder structure.

please review.

[daira]

Replying to dawuud:

Question to Tahoe-LAFS developers: why does CreateAliasOptions inherit from FilesystemOptions?

Because tahoe create-alias accesses the filesystem! (It creates a directory.)

[daira]

We finished reviewing this today (see ​https://github.com/tahoe-lafs/tahoe-lafs/pull/174/files).

[daira]

This is implemented and tested.

[warner]

Milestone renamed