`tahoe status` unhandled KeyError: 'progress'

[exarkun]

$ tahoe status 
Statistics (for last 2 seconds):
    uploaded 0 B in 0 files
  downloaded 0 B in 0 files

Active operations:
╓ type  ╥ storage index              ╥ progress               ╥ status message
╟───────╫────────────────────────────╫────────────────────────╫─────────────────────
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "site-packages/twisted/_threads/_threadworker.py", line 46, in work
    task()
  File "site-packages/twisted/_threads/_team.py", line 190, in doWork
    task()
--- <exception caught here> ---
  File "site-packages/twisted/python/threadpool.py", line 250, in inContext
    result = inContext.theWork()
  File "site-packages/twisted/python/threadpool.py", line 266, in <lambda>
    inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
  File "site-packages/twisted/python/context.py", line 122, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "site-packages/twisted/python/context.py", line 85, in callWithContext
    return func(*args,**kw)
  File "tahoe-lafs/src/allmydata/scripts/cli.py", line 579, in status
    return tahoe_status.do_status(options)
  File "tahoe-lafs/src/allmydata/scripts/tahoe_status.py", line 146, in do_status
    total = op['progress']
exceptions.KeyError: 'progress'

This is moderately reproduceable against my client node. Hacking the code a bit, I see that when it occurs, op (at least sometimes) is:

{u'mode': u'MODE_READ',
 u'status': u'Sending 1 initial queries',
 u'storage-index-string': u'vfl23nfdydohpriimglb7dynje',
 u'total-size': u'-NA-',
 u'type': u'mapupdate'}

[exarkun]

From the implementation of allmydata.web.status.Status it looks like only IDownloadStatus items have a "progress" key. The CLI-side rendering code assumes that if "progress-hash" is not present then "progress" will be. However, there are six cases represented by the Status renderer. And, indeed, "mapupdate" is one of those other cases.

So, the CLI-side rendering code needs to support these other cases as well.

[exarkun]

​https://github.com/tahoe-lafs/tahoe-lafs/pull/502

[GitHub <noreply@…>]

In 28a2e6e/trunk:

Merge pull request #502 from exarkun/2926.cli-status-exceptions

Fix several cases where tahoe status rendering raises an unhandled exception.

Closes ticket:2926

Some possible operation states were not accounted for.