Opened at 2020-08-30T15:14:54Z

Last modified at 2023-09-05T14:20:22Z

#3398 assigned enhancement

Add pre-commits with lint checks

Reported by: jaraco Owned by: jaraco
Priority: normal Milestone:
Component: unknown Version: n/a
Keywords: Cc:
Launchpad Bug:

Description

CI includes "code checks" including flake8 checks. It's common for a developer to make changes, test, commit, then push only to find that linter checks fail. To avoid this unwelcoming workflow, the team would like to declare pre-commit hooks that a developer could run to avoid committing code that will fail code checks (at least flake8).

Change History (6)

comment:1 Changed at 2020-08-30T15:48:52Z by jaraco

  • Owner set to jaraco
  • Status changed from new to assigned

comment:2 Changed at 2020-09-02T02:05:01Z by jaraco

  • Keywords review-needed added

comment:3 Changed at 2020-09-04T14:53:01Z by meejah

  • Keywords review-needed removed

comment:4 Changed at 2020-09-12T13:53:51Z by jaraco

PR: ​https://github.com/tahoe-lafs/tahoe-lafs/pull/798

It's failing due to flaky tests.

comment:5 Changed at 2020-09-27T15:56:36Z by rpatterson

Here's ​another PR that runs the full test suite before allowing a push and includes setting up the hook in the local checkout into the ./Makefile.

comment:6 Changed at 2023-09-05T14:20:22Z by itamarst

  • Milestone Support Python 3 deleted

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.