#350 closed defect (fixed)

have xfer-client return an error code if it doesn't succeed

Reported by: zooko Owned by: warner
Priority: major Milestone: undecided
Component: dev-infrastructure Version: 0.9.0
Keywords: Cc:
Launchpad Bug:

Description

This attempt to upload tarballs failed due to insufficient write permissions:

http://allmydata.org/buildbot/builders/gutsy/builds/582/steps/upload-tarballs/logs/stdio

But the buildstep was green, which led to the problem not being discovered for a while.

It looks like xfer-client might not be returning an error code for this case.

Change History (2)

comment:1 Changed at 2008-06-01T21:03:21Z by warner

  • Milestone changed from eventually to undecided

comment:2 Changed at 2009-12-27T16:50:54Z by warner

  • Resolution set to fixed
  • Status changed from new to closed

I've replaced the old xfer-client with a modern flappclient call (in eff82174d50cb326), and set up a corresponding flappserver in the 'source' account on allmydata.org . We still need to:

  • replace the gutsy buildslave (which is where the tarballs used to be generated and uploaded)
  • copy the flappserver's FURL into the new buildslave

But since flappclient properly returns an error code for failed uploads, even when the target directory has lost write permission after the flappserver was started, I'm now closing out this ticket.

Note: See TracTickets for help on using tickets.